Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add multi-role assignment support for users #7037

Merged
merged 6 commits into from
Nov 24, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Nov 15, 2024

What type of PR is this?

/area ui
/kind feature
/milestone 2.20.x

What this PR does / why we need it:

支持为用户分配多个角色。

image image

TODO:

  • Console / UC 侧边栏显示多个角色
  • 支持在管理端查看用户聚合的角色模板列表,或者在分配时显示所选角色其下的角色模板列表,能够让管理员清楚的知道用户具体权限。

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

支持为用户分配多个角色。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added the area/ui Issues or PRs related to the Halo UI label Nov 15, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Nov 15, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 15, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wan92hen November 15, 2024 12:41
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 15, 2024
@ruibaby ruibaby changed the title feat: add multi-role assignment support for users WIP: feat: add multi-role assignment support for users Nov 15, 2024
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.25%. Comparing base (eff73dc) to head (2c7219c).
Report is 58 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7037      +/-   ##
============================================
+ Coverage     56.99%   57.25%   +0.25%     
- Complexity     3999     4009      +10     
============================================
  Files           714      712       -2     
  Lines         24110    24144      +34     
  Branches       1585     1592       +7     
============================================
+ Hits          13742    13824      +82     
+ Misses         9756     9705      -51     
- Partials        612      615       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

sonarcloud bot commented Nov 22, 2024

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 22, 2024
@ruibaby ruibaby changed the title WIP: feat: add multi-role assignment support for users feat: add multi-role assignment support for users Nov 22, 2024
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2024
@ruibaby ruibaby requested review from JohnNiang and LIlGG November 22, 2024 06:36
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

image

image

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2024
Copy link

f2c-ci-robot bot commented Nov 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 391aac6 into halo-dev:main Nov 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants